Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Megafauna] Add weakpoints and anatomical proficiencies #63590

Merged
merged 14 commits into from
Aug 5, 2023
Merged

[Megafauna] Add weakpoints and anatomical proficiencies #63590

merged 14 commits into from
Aug 5, 2023

Conversation

merrygin
Copy link
Contributor

@merrygin merrygin commented Feb 14, 2023 •
edited
Loading

Summary

Mods "Add weakpoints system to Megafauna mod"

Purpose of change

Fixes #62491
Megfauna creatures do not have anatomical proficiencies nor weakpoints that make those useful yet. Purpose is rectifying that.

Describe the solution

  • Add families "simple biology"
  • Add weakpoints (default stuff for the smaller creatures)
  • Add "megfaunal biology" family (?)
  • Add weakpoints (new and specific to actual megafauna)

Describe alternatives you've considered

Just simple biology and copy and paste weakpoints just to have something quick, but I'd like to take the time and do it properly.

Testing

tbd

Additional context

Tweaked (buffed, mostly) most armor values as well to make WPs more important.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions labels Feb 14, 2023
@merrygin @github-actions
Update data/mods/Megafauna/monsters/mf_domestic.json
9d1d296 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Feb 16, 2023
@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Feb 20, 2023
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 20, 2023
@merrygin @github-actions
Update data/mods/Megafauna/mf_weakpoint_sets.json
5a4b8dc 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@merrygin merrygin marked this pull request as ready for review April 9, 2023 10:02
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Apr 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2023

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • You have ripped the %s bowels! The % is wretching.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@merrygin
Copy link
Contributor Author

merrygin commented Apr 9, 2023

@LyleSY , sorry for pinging, but would you terribly mind to have a look if this looks sensible? I mainly oriented myself on the dino weakpoints, but added some stuff (like striking vitals, easier targetting of downed animals) and I'm not sure if the values are sensible like that.

LyleSY
LyleSY approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@LyleSY LyleSY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the logic and the specific values here make sense to me. Playtesting may show some things I can't see, but this all looks great to me

@merrygin
Copy link
Contributor Author

All of the logic and the specific values here make sense to me. Playtesting may show some things I can't see, but this all looks great to me

Thanks a bunch!

@Maleclypse Maleclypse merged commit 9463676 into CleverRaven:master Aug 5, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maleclypse Maleclypse Maleclypse left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@ZhilkinSerg ZhilkinSerg ZhilkinSerg left review comments

@LyleSY LyleSY LyleSY approved these changes

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods Issues related to mods or modding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MegaFauna] Add Relevant Proficiencies to Megafauna
5 participants
@merrygin @ZhilkinSerg @LyleSY @Maleclypse @dseguin